Add z dep #33
Merged
Add z dep #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getting in sync with upstream
Owner
|
i do not understand the outer product you are performing now in the fisher part. since we are doing only vv, the outer product should be the same thing. |
Owner
There was a problem hiding this comment.
This is not very general but we can consider it to be true if we do not add the sigma_8 dependency.
Collaborator
Author
There was a problem hiding this comment.
Is this resolved, at least notionally? I spent the day looking for bugs and actually reimplementing to get the same answer.
organize code
Fix carreres to work in new API
Collaborator
Author
|
I have now added a constant I compared with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications made in order for the code to run and give a reasonable answer.
The calculation of the partial derivatives in fisher_terms.py is different. I believe (?!) the new implementation is correct. The old implementation gave unreasonable results.
Implemented Om0-gamma model in rcrk24.